fix(context): keep _partition in bounds when nothing is kept - #12
Merged
Merged
Conversation
``keep_recent=0`` — how a caller asks for the whole history to be summarised — made ``split_idx == len(rest)``, which is neither the forward nor the backward case of the orphan guard added in e4908c8: the forward walk has nothing to scan, and the ``else`` branch indexed ``rest[len(rest)]``. The kept window is empty there, so no orphan tool result is possible and both walks are meaningless. Leave the split alone instead. Callers that summarise a finished session (``SessionHistoryCompactor._summarize`` and apodex's explicit compaction) wrap ``compact()`` in ``try/except``, so the IndexError surfaced as "no summary available" and the whole rollup was lost silently. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keep_recent=0— how a caller asks for the whole history to be summarised — madesplit_idx == len(rest), which is neither the forward nor the backward case of the orphan guard added in e4908c8: the forward walk has nothing to scan, and theelsebranch indexedrest[len(rest)].The kept window is empty there, so no orphan tool result is possible and both walks are meaningless. Leave the split alone instead.
Callers that summarise a finished session (
SessionHistoryCompactor._summarizeand apodex's explicit compaction) wrapcompact()intry/except, so the IndexError surfaced as "no summary available" and the whole rollup was lost silently.