escape quoted-string params in Digest Authorization header#2236
Merged
hyperxpro merged 1 commit intoJul 9, 2026
Merged
Conversation
hyperxpro
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
computeDigestAuthentication echoes the realm, nonce and opaque values from the server's Digest challenge into the quoted-string params of the outgoing Authorization header via append(), which wrapped them in quotes without escaping. matchParam returns an unquoted challenge value up to the next comma or space, so a bare double quote survives, and a server sending nonce=abc"x makes that quote close the value early and inject stray auth-params into the credentials the client emits toward any proxy or gateway on the path. append() now backslash-escapes double-quote and backslash per the RFC 7230/7616 quoted-string rules, covering both the origin and proxy Digest paths since they share this helper. Base64/hex nonces are unaffected; AuthenticatorUtilsTest gets a case that fails without the escaping.