feat: Add security, linting, and threat-model enhancements - #969
Merged
fejilaup-cloud merged 4 commits intoAug 31, 2026
Merged
Conversation
- Add .eslintrc.json with style rules for consistent code formatting - Add .prettierrc and .prettierignore for automated formatting - Update package.json with lint/format npm scripts - Add lint and format checks to CI pipeline Closes AtomicIP#914
- Add mandatory audit checklist for re-enabling previously-disabled tests - Document security-critical test modules requiring manual sign-off - Cross-reference threat model and security procedures - Specify fund safety, authorization, and upgrade safety requirements Closes AtomicIP#913
- Document JS batch layer trust boundary and authority model - Add threat analysis for compromised batch hosts, state injection, replay attacks - Clarify that batch processes prepare unsigned requests; API server holds signing authority - Include implementation checklist and operator recommendations - Explain how audit logs and idempotency keys mitigate batch-layer risks Closes AtomicIP#912
- Add .gitleaks.toml configuration with patterns for keypairs, API keys, JWTs - Integrate gitleaks-action into CI to scan all commits for secrets - Document secret scanning in SECURITY.md with full history and PR scan coverage - Add incident response procedure for exposed secrets - Include local scanning instructions and pre-commit hook guidance Closes AtomicIP#911
|
@ssins2013-dotcom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 4 security and infrastructure improvements across the AtomicIP project:
Test Plan
Changes
Commit 1: Add ESLint and Prettier configuration (#914)
.eslintrc.json: Style rules for consistent formatting.prettierrc/.prettierignore: Automated formatting configpackage.json: Added lint/format npm scripts.github/workflows/ci.yml: Added lint and format checks to CICommit 2: Add security review checklist (#913)
SECURITY.md: Mandatory audit checklist for re-enabling disabled test modulesCommit 3: Add threat-model section for JS batch layer (#912)
docs/threat-model.md: New section covering JS batch trust boundaryCommit 4: Add secret scanning with gitleaks (#911)
.gitleaks.toml: Configuration with patterns for Stellar keypairs, JWT secrets, API keys.github/workflows/ci.yml: Integrated gitleaks-action to scan commitsSECURITY.md: Documented secret scanning, incident response, and local scanning instructionsCloses #914
Closes #913
Closes #912
Closes #911