examples: Pin privileged nsenter DaemonSets to MCR alpine - #5960
Open
Sebastien Tardif (SebTardif) wants to merge 1 commit into
Open
Sebastien Tardif (SebTardif) wants to merge 1 commit into
Sebastien Tardif (SebTardif) wants to merge 1 commit into
Conversation
Replace unpinned image: alpine with mcr.microsoft.com/azure-policy/alpine:prod_20200505.1 on the three privileged hostPID DaemonSets. Matches disable-azsecd and other sibling remediations. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Sebastien Tardif (SebTardif)
requested review from
a team and
Maya (mayasingh17)
and
a lite review from Copilot
September 9, 2026 16:49
Sebastien Tardif (SebTardif)
requested review from
a team and
Jorge Palma (palma21)
as code owners
September 9, 2026 16:49
Copilot started reviewing on behalf of
Sebastien Tardif (SebTardif)
September 9, 2026 16:49
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are a straightforward, consistent image pin across the specified manifests with no functional or structural YAML issues introduced.
Pull request overview
This PR improves supply-chain safety and repeatability for privileged nsenter DaemonSet examples by replacing the unpinned alpine image reference with a pinned Microsoft Container Registry (MCR) Alpine image that’s already used by other remediations in this repo.
Changes:
- Update
image: alpinetoimage: mcr.microsoft.com/azure-policy/alpine:prod_20200505.1in three privileged host-namespace DaemonSet manifests. - Keep commands, privileges, and
imagePullPolicyunchanged to preserve example behavior.
File summaries
| File | Description |
|---|---|
| examples/runc/downgraderunc.yaml | Pins the nsenter container image to the repo’s existing MCR Alpine tag. |
| examples/kubelet/kubelet-parameters-ds.yaml | Pins the DaemonSet container image to the same MCR Alpine tag for consistency and determinism. |
| examples/kubelet/enable-anonymous-auth-for-non-rbac.yaml | Pins the nsenter container image to the repo’s existing MCR Alpine tag. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Mutaz Nassar (@mutazn) and Jorge Palma (@palma21) to review as original creators of these. I do note these examples are quite old, so not sure if they are still applicable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the three privileged host-nsenter DaemonSets to the same MCR Alpine image the other remediations in this repo already use.
Problem
These examples run
privileged: truewithhostPID/hostNetworkand pull unpinnedimage: alpine(implicit latest) withIfNotPresent:examples/kubelet/enable-anonymous-auth-for-non-rbac.yamlexamples/kubelet/kubelet-parameters-ds.yamlexamples/runc/downgraderunc.yamlA first pull of
alpine:latestbecomes whatever Docker Hub served that day, then stays cached. Sibling remediations already pinmcr.microsoft.com/azure-policy/alpine:prod_20200505.1(disable-azsecd.yaml,iptables/snat_exemption_ds.yaml,unattended-upgrades/daemonset.yaml).Present since the original manifests (
9d0e5f6072021-05-06,b4c5e6c9d2021-03-30).Change
Replace
image: alpinewithmcr.microsoft.com/azure-policy/alpine:prod_20200505.1in those three files only. Commands and security context are unchanged.Validation
Mechanical pin to an existing in-repo image. No example test harness for these YAML files. Confirmed with
rgthat the three files no longer useimage: alpineand match the sibling tag.Related
examples/disable-azsecd.yaml