Manage site asset lifecycle and quick link previews - #67
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Completed uploads were durable before their owning form or document saved. This left canceled quick-link uploads and replaced brand images in object storage. Favicons also stored raw URLs, so the backend could not manage their lifecycle.
Data migration
The development and production Convex deployments were migrated before the legacy schema fields were removed. Existing favicon URLs were converted to file IDs, release snapshots were updated, and 209 existing site-asset rows were classified from their current draft and release references. Six expired development objects were physically removed.
Post-migration audits report zero legacy assets and zero reference-state anomalies in both environments. Development has 89 referenced attached assets and three active pending uploads. Production has 110 referenced attached assets and one active pending upload. Neither environment has an object due for deletion.
Validation
bun test— 233 tests passedbun run lintbun run check-typesbun run buildbunx biome check .The deployed preview, migrations, storage deletion, and all CI checks are complete.