Skip to content

Refine site sharing dialogs - #69

Merged
naaiyy merged 1 commit into
mainfrom
agent/refine-share-dialog
Aug 14, 2026
Merged

Refine site sharing dialogs#69
naaiyy merged 1 commit into
mainfrom
agent/refine-share-dialog

Conversation

@naaiyy

@naaiyy naaiyy commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • simplify the share dialog to public and private visibility options
  • move page guest access to its own dialog
  • replace native permission menus with ShadCN selects

Validation

  • bunx @biomejs/biome@2.5.3 check for changed UI and message files
  • bun run --cwd apps/web check-types
  • bun test apps/web/features/openeditor/custom-blocks.test.ts apps/web/features/openeditor/custom-block-menu.test.ts

@github-actions

Copy link
Copy Markdown

React Doctor found 2 new issues in 2 files · 2 errors · score 76 / 100 (Needs work) · 3 fixed · vs main

Errors

Reviewed by React Doctor for commit 8559423. See inline comments for fixes.

const handleInvite = async (event: React.FormEvent<HTMLFormElement>) => {
event.preventDefault();
setSubmitting(true);
try {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Doctor · react-hooks-js/todo (error)

This component misses React Compiler's automatic memoization & re-renders more than it should. Rewrite the flagged code so the compiler can optimize it.

Fix → Todo: (BuildHIR::lowerStatement) Handle TryStatement with a finalizer ('finally') clause

Docs

const handleVisibilityChange = async (value: string) => {
if (value === visibility || updating) return;
setUpdating(true);
try {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Doctor · react-hooks-js/todo (error)

This component misses React Compiler's automatic memoization & re-renders more than it should. Rewrite the flagged code so the compiler can optimize it.

Fix → Todo: (BuildHIR::lowerStatement) Handle TryStatement with a finalizer ('finally') clause

Docs

@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
base-blocks Ready Ready Preview Aug 14, 2026 6:41pm

Request Review

@naaiyy
naaiyy merged commit 043dba3 into main Aug 14, 2026
9 checks passed
@naaiyy
naaiyy deleted the agent/refine-share-dialog branch August 14, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant