Skip to content

Fix spurious timeout warnings for empty connections - #164

Merged
BenCodez merged 3 commits into
masterfrom
fix/empty-connection-timeout-warning
Jul 28, 2026
Merged

Fix spurious timeout warnings for empty connections#164
BenCodez merged 3 commits into
masterfrom
fix/empty-connection-timeout-warning

Conversation

@BenCodez

@BenCodez BenCodez commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • distinguish clean EOF from a socket that remains open without sending a vote payload
  • treat zero-byte clean disconnects as benign debug events instead of timeout warnings
  • preserve the existing two-second warning for genuinely silent open connections
  • replace the polling loop with a blocking one-byte read and pushback

Tests

  • clean close after handshake returns promptly with no warning
  • silent open connection still logs the timeout warning
  • delayed valid V1 payload still parses correctly and preserves the first byte

This addresses empty companion/probe connections such as the reported MinecraftIPList pattern without reducing visibility for actual stalled sockets.

AI disclosure: This pull request was created with assistance from AI.

@BenCodez
BenCodez merged commit f4edee0 into master Jul 28, 2026
1 check passed
@BenCodez
BenCodez deleted the fix/empty-connection-timeout-warning branch July 28, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant