Allow expand writtenLines + msPartsCount in expanded ODD - #47
Merged
Merged
Conversation
tei_odds forbids minOccurs/maxOccurs on macroRef; macro.specialPara already admits empty content for writtenLines-only computed layouts. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<writtenLines quantity="…"/>underlayout[@subtype='computed'](replaces TEI design: computed physical dimensions (parallel @subtype siblings) #45/#44docs that usedlayout/@writtenLineson the computed sibling)<msPartsCount quantity="…"/>onmsDesc(materializedcount(msPart); TEI design: computed physical dimensions (parallel @subtype siblings) #45 had left this as a live count)citeStructure/@unit(token / no whitespace stays; multi-word units are an expand fix).RNG regenerates on merge to
mastervia existing Schema CI.Failure taxonomy (full-corpus RNG ~8%)
writtenLineselement under computedlayoutlayoutmsPartsCountlast child ofmsDescmsPart/msFragat endciteStructure/@unitwith spaces (page break, label prose)teidata.enumeratedcorrectly forbids whitespace; normalize units in expand<source-url>sourceDesc/ unexpectedmsDescstyle reportsmsPartsCount) makes parent alternatives failDo not re-enable expanded corpus RNG CI until this lands and expand cleans citeStructure units / source-url.
Refs: Schema #45, BetMasWeb expand-normalize-dimensions.
Test plan
msPartsCount(e.g. UNESCO702, DabSey001) against regeneratedtei-betamesaheft-expanded.rngunit="page break"still fail until expand fixMade with Cursor