Skip to content

Allow expand writtenLines + msPartsCount in expanded ODD - #47

Merged
duncdrum merged 2 commits into
masterfrom
dp-expanded-computed-quantity-elements
Sep 4, 2026
Merged

duncdrum merged 2 commits into
masterfrom
dp-expanded-computed-quantity-elements

Conversation

@duncdrum

@duncdrum duncdrum commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

RNG regenerates on merge to master via existing Schema CI.

Failure taxonomy (full-corpus RNG ~8%)

Class Whose job Notes
writtenLines element under computed layout Schema (this PR) Expand intentional; current RNG only allows phrase content under layout
msPartsCount last child of msDesc Schema (this PR) Expand intentional; RNG expects only msPart/msFrag at end
citeStructure/@unit with spaces (page break, label prose) Expand teidata.enumerated correctly forbids whitespace; normalize units in expand
Leftover <source-url> Expand Non-TEI artefact; strip, do not schema-allow
Many sourceDesc / unexpected msDesc style reports Often cascade Illegal child (e.g. msPartsCount) makes parent alternatives fail

Do not re-enable expanded corpus RNG CI until this lands and expand cleans citeStructure units / source-url.

Refs: Schema #45, BetMasWeb expand-normalize-dimensions.

Test plan

  • Schema CI green (ODD jing + TEIGarage RNG build)
  • After merge: spot-check jing on files with computed layout + msPartsCount (e.g. UNESCO702, DabSey001) against regenerated tei-betamesaheft-expanded.rng
  • Confirm files with unit="page break" still fail until expand fix

Made with Cursor

duncdrum and others added 2 commits September 4, 2026 11:37
Catch expanded schema up to locked BetMasWeb expand-normalize encoding:
empty writtenLines/@quantity under computed layout, and trailing
msPartsCount/@quantity on msDesc. citeStructure/@Unit stays strict.

Co-authored-by: Cursor <cursoragent@cursor.com>
tei_odds forbids minOccurs/maxOccurs on macroRef; macro.specialPara
already admits empty content for writtenLines-only computed layouts.

Co-authored-by: Cursor <cursoragent@cursor.com>
@duncdrum
duncdrum marked this pull request as ready for review September 4, 2026 09:42
@duncdrum
duncdrum merged commit d477ec0 into master Sep 4, 2026
2 checks passed
@duncdrum
duncdrum deleted the dp-expanded-computed-quantity-elements branch September 4, 2026 09:44
@duncdrum duncdrum added this to the Jinntec_Phase_Docker milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant