Improve macOS support and GitHub release updates#2
Merged
Birditch merged 12 commits intoJul 10, 2026
Conversation
- CliLauncher: branch by platform. macOS now writes an equivalent .command shell script with the same numbered menu and opens it in Terminal.app; previously it hardcoded cmd.exe + .bat and failed silently on macOS. - Surface launch failures via Notifier (toast) instead of only logging. - Add cli.unsupported / cli.launchFailed strings to both ResX files. - Packaging: generate AppIcon.icns from atv-icon.png (sips + iconutil) and set CFBundleIconFile so the macOS .app shows an icon in Dock/Finder.
Sync version across AppInfo, App/Mini/Mini.Mac project metadata, app.manifest, packaging scripts, wix, docs, and README.
- Platform badge Windows -> Windows + macOS - Describe as cross-platform (Windows + macOS Apple Silicon), not Windows-only - Generalize the usage section and add a macOS subsection (Terminal.app CLI, drag to /Applications, Gatekeeper). English README already covered this.
分步向导:上传刷机包→提取 boot.img→手机端官方 Magisk 修补→进 bootloader→flash boot,写操作前强制确认+自动备份原始 boot。双平台(Windows/macOS)。
- 构建时打包固定版 Magisk APK(SHA-256 校验),运行时 adb install - 修补改用已装 App 自带的 boot_patch.sh + native 组件,不再桌面侧拆各 ABI 二进制 - 同步 §1.1/§2/§3/§4/§5.1/§6.2/§7/§8/§10/§11/§13 - 保留第 4 步实机验证警告(已装 App 脚本能否被 adb shell 直接调到仍待验证)
…con' into fix/macos-cli-terminal-and-app-icon # Conflicts: # CLAUDE.md
Owner
|
/chatgpt-review |
1 similar comment
Owner
|
/chatgpt-review |
ChatGPT PR 初审我会先看更新服务和打包脚本的实际改动,因为这类 PR 最容易出现发布或自动更新层面的用户可见问题。重点会放在是否会破坏现有 Windows 自动更新、macOS 打包是否能产出可运行包。 结论建议通过。基于提供的 diff,未发现会导致构建失败、发布包损坏、自动更新不可用、安全漏洞或明确用户可见故障的阻塞问题。本建议仅为自动化预审,不代表维护者正式批准。 阻塞问题无 非阻塞建议
这是自动初审建议,不代表维护者正式批准。第三方 PR 的代码没有在此 workflow 中执行。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取请求 (Pull Request)
摘要 (Summary)
改进 AndroidTreeView 的 macOS 支持,并将应用更新源迁移到公开的 GitHub Releases。macOS CLI 现在通过 Terminal.app 启动;
.app打包包含规范尺寸的 ICNS 图标、可保留的签名和正确权限;App/Mini 使用程序集发布版本并从 GitHub 获取版本、资产、校验文件和发布说明。SIGN 声明 (SIGN Declaration)
(I certify that I have the right to submit this work and agree it is provided under this repository's license.)
类型 (Type)
细节 (Details)
macOS
cmd.exe路径。.appbundle,包含 ICNS、安全区尺寸、执行权限和 ad-hoc 签名。ditto打包,确保 ZIP 解压后签名扩展属性仍然有效。更新与版本
发布与文档
1.0.6同步到程序集、manifest、打包配置和文档。安全影响 (Security Impact)
(No GitHub Actions, release scripts, packaging scripts, or binary artifacts were changed.)
(If sensitive areas were changed, I explained why in the summary or details.)
本 PR 修改发布和打包文件,以支持 GitHub Releases 更新、macOS
.app签名及 ICNS 安全区。第三方 PR 安全门禁会按设计要求维护者手动审阅这些文件。验证 (Verification)
dotnet build -c Release通过 (build succeeds).dotnet test -c Release通过 (tests pass).dotnet format --verify-no-changes(或已格式化)(code is formatted).验证结果:全量测试
270/270通过;Release 构建 0 警告、0 错误;macOS arm64 ZIP 的校验和、bundle 结构、权限、release.json、ICNS 安全区和解压后签名均已验证。关联 Issue (Related Issues)
无。