fix: preserve CLI review and explanation context - #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid V2 invoice creation could fail standalone
bb checkbecause normalization lost the explicit creation context and treated frozen terms as an update. Preserve that context using the existing normalization helper while retaining rejection of immutable updates, including malformed collection IDs.bb explainnow accepts successful saved CLI output, rejects failed/malformed envelopes, and uses creation or update context consistently for each collection message.bb --versionreads installed package metadata. Prepares patch release 0.45.5 without dependency changes.Validation: 189 suites / 3,730 unit tests and 28 built-CLI regressions passed, including all nine payment presets through build → full check → explain. ESM/CJS builds, imports, cycle checks, source/ESM/CJS version reporting, and the related-repo script test passed. Independent review verified input preservation, malformed-envelope rejection, and immutable-update protection. All checks were unsigned; no signing or broadcasting performed.