fix(sdk-coin-sui): skip splitCoins entirely when the full amount with…#9182
Merged
Conversation
Contributor
abhishekagrawal080
force-pushed
the
CSHLD-1146
branch
from
3a07dd9 to
95cb268
Compare
nvrakesh06
previously approved these changes
Jul 3, 2026
abhishekagrawal080
force-pushed
the
CSHLD-1146
branch
from
95cb268 to
112ddb8
Compare
nvrakesh06
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…drawn
TICKET: CSHLD-1146
Root Cause:
Native SUI — already cleaned up: No changes is needed
MoveCall(redeem_funds, 0x2::sui::SUI) → addrCoin: Coin
SplitCoins(addrCoin, [amount]) → split: Coin
TransferObjects([split], recipient)
MergeCoins(GasCoin, [addrCoin]) ← GasCoin is also Coin ✓
MergeCoins(GasCoin, [addrCoin]) is type-valid because both operands are Coin. The zero-balance addrCoin is absorbed into gas — consumed, no unused value.
Token — no compatible merge target: Need handling
MoveCall(redeem_funds, 0x..::deep::DEEP) → addrCoin: Coin
SplitCoins(addrCoin, [amount]) → split: Coin
TransferObjects([split], recipient)
MergeCoins(GasCoin, [addrCoin]) ← GasCoin is Coin, addrCoin is Coin ✗ type error
Gas is always Coin. You can't merge a Coin into it. There's no existing coin of type Coin in the PTB to merge into either (we just drained the only one). So addrCoin sits unconsumed → UnusedValueWithoutDrop.