feat(erc7730): D-I iteration and signer-constant intent check - #118
Closed
BitHighlander wants to merge 2 commits into
Closed
BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
D-I iteration compiler mirror, stacked on D-G #117. Enables one array reached through tuples, requires every iterating formatter path to bind to the active value array, and retains fixed-array coverage.
The split audit found the old D tuple check read mixed_arrays instead of value_literal. It now checks the fourth member. The inherited signer-constant regression fails with the old code and passes with the fix. Firmware already rejected the malformed intent.
Validation
18 compiler/validator cases pass without skips, including 1,450 registry formats and 1,273 signable. The group/optional controls and signer-constant regression remain in this child. Preserves historical #115; new review unit starts with zero attempts.