test(erc7730): Stack 08 embedded replay and evidence contracts - #120
Draft
BitHighlander wants to merge 2 commits into
Draft
BitHighlander wants to merge 2 commits into
BitHighlander wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds Stack 08 ERC-7730 embedded-call security tests, transport-chunk coverage, and report validation.
Changes:
- Adds EX40–EX44 runtime attack and cancellation tests.
- Validates fragmented transport replies and definition identity.
- Registers required full-product report controls and OLED sequence coverage.
| File | Description |
|---|---|
tests/test_report_variant_validation.py |
Validates required full-product coverage. |
tests/test_msg_ethereum_erc7730_runtime.py |
Adds embedded-call security and cleanup tests. |
scripts/generate-test-report.py |
Registers EX40–EX44 and ordered OLED reporting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 08 companion
Base: consolidated 7b Python #119 (
5c2dd4dbce5096de393b2db8c925f24950e22d8b). Head:d9a02d981ee43fe3e80b28ba02466670e6e8409d.Adds five embedded-call wire contracts: large inner data across 31/1,024-byte replies, altered outer bytes during inner review, replacement of the saved parent definition, ID changes between inner definition chunks, and cancellation/preload cleanup without Initialize. Every predecessor runtime test body is AST-identical (39 retained, five added). Production
keepkeylibis unchanged.Registers EX40–EX44 and full-product report requirements, plus an ordered OLED sequence for parent restoration refusal. Negative report controls reject missing/skipped/failed full results and accept expected Bitcoin-only skips.
Local qualification on the accepted 7b emulator: 65 wire/runtime tests, 39 compiler/catalog/protocol/report tests with required firmware/registry evidence, 657 native tests, EX42's 11 inspected OLED frames. Four attack/cancellation controls fail when the injection is disabled; ignoring small transport chunks also fails. Firmware preflight on the matching pin passed all Stage-1 mirrors before this push.
Firmware Stack 08 draft is #872, head
68f0b18247b469caf7b9fa86de39383b2b1b33f6; the initial full/BTC CI passed, and final-head CI/report verification is pending after the firmware report-gate repair. Scope follows the current 7.15 owner handoffs: deeper recursion, additional hiding conditions and DELEGATECALL policy remain deferred. No release promotion or device validation is claimed.Adjacent inventory:
Copilot review 5329239805 is clean on this Python head, with zero findings and zero unresolved threads. Firmware companion has a repaired waiver-authority finding and awaits new exact-head CI/review. Initial requests used: 2/3; no breakdown.
Repaired-head verification before final initial request
CI 36302640527 passed every required job on
68f0b18247b469caf7b9fa86de39383b2b1b33f6: 1,497 pass, 89 expected skips, zero failures/errors. Manifest binds both PRs, both exact commits and this run. PDF SHA256757634457f6921fc9991c25068ed30dd45c0bb03c8bd185d42c88f2b63bb088c; both ARM variants verified. Python CircleCI 548 remains green. All prior threads are resolved. Request 3/3 will review the immutable-authority repair on this frozen code-bearing diff.Current firmware replacement stack
Firmware aggregate #872 is now 73ad3a27ba000e2e3350bc3e72c6f8cbc53484ad, CI 36304802833. One authorized binary split provides review units A #873 (report evidence) and B #874 (preflight). This Python head remains unchanged and clean in review 5329239805. All six later firmware findings are repaired and resolved; child CI/reviews remain pending. This supersedes earlier firmware-head/status entries.