You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Save interrupted recordings when the Mac or display sleeps, so stopping afterward no longer fails with “stream already stopped.”
Saved audio remains in Audio < Library for manual transcription, with a notice shown when the user returns. System sleep waits up to 30 seconds for saving to finish.
[P2] The interruption fallback can still delete captured audio — SystemAudioMeetingRecorder.swift:157
When prepareForInterruption() has run but stopCapture() throws another error, such as failedToStopAudioCapture, this branch calls audioWriter.cancel(). That already deletes the temporary file; skipping the subsequent removeItem cannot preserve it. My reproduction left neither temporary nor final audio. Marked interruptions should attempt to finalize the captured samples before cancellation.
[P2] An interruption during startup is silently dropped — SystemAudioMeetingRecorder.swift:524
self.stream is assigned only after await stream.startCapture(). If the delegate reports an interruption while that call is suspended, this guard discards it. Startup subsequently sets isRecording = true for the stopped stream. Track the pending stream and retain startup failures before awaiting capture startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save interrupted recordings when the Mac or display sleeps, so stopping afterward no longer fails with “stream already stopped.”
Saved audio remains in Audio < Library for manual transcription, with a notice shown when the user returns. System sleep waits up to 30 seconds for saving to finish.