Skip to content

2nd of #575 - #578

Open
Lazarus-931 wants to merge 1 commit into
mainfrom
artifacts-2-of-575
Open

Lazarus-931 wants to merge 1 commit into
mainfrom
artifacts-2-of-575

Conversation

@Lazarus-931

@Lazarus-931 Lazarus-931 commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Unify the artifact catalog, reuse stored files, and remove references across linked sessions.

Stacked on #577. Saves are sequential: failures can leave partial removal; remaining references can be retried.

Verified: local build and 35 tests passed

@Lazarus-931 Lazarus-931 mentioned this pull request Sep 16, 2026
@Lazarus-931
Lazarus-931 added this pull request to stack #579 September 16, 2026 16:52
@Lazarus-931 Lazarus-931 mentioned this pull request Sep 16, 2026
Base automatically changed from artifacts-1-of-575 to main September 18, 2026 18:52
@lucasnewman

Copy link
Copy Markdown
Collaborator

@Lazarus-931 Codex review:

[P2] Deleted artifacts can remain visible in another window.
The fingerprint is shared on disk, but known belongs to each window. After window A deletes an artifact and updates the fingerprint, window B can return its stale catalog because the underlying shared file still exists. The new mutationRevision only protects the window performing deletion. Remove this shortcut or associate each in-memory catalog with its own fingerprint. ArtifactStore.swift:337–343

[P2] Migration leaves obsolete copies of deleted files behind.
The rebuild switches to shared media references and removes the old cache-pruning code, but never cleans existing Caches/Nativ/Artifacts files. Those copies survive subsequent artifact deletion—even after shared-media garbage collection. This retains deleted content and wastes disk space. Add cleanup of obsolete copies during migration. ArtifactStore.swift:346–350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants