Merge ROS2 SLAM/NAV integration branch to develop - #236
Open
jonpg01 wants to merge 13 commits into
Open
Conversation
* fix(APPRemoteControl): add ROBOT_SET channel and fix initial pose handling * chore: remove default PIO envs * docs: fix typos * fix(APPRemoteControl): improve logs
webots-controller crashes with SIGSEGV (exit 139) in libController.so when the remote Webots host closes the TCP connection. Replace the raw shell action with a subprocess wrapper that treats exit code 139 as success, since the DCS process itself exits cleanly at that point. Also replace `return status` with `exit(status)` in main() to bypass C++ static destructor teardown: ~webots::Robot() calls wb_robot_cleanup() and ~MqttClient() calls mosquitto_loop_stop(), both of which crash or block when the Webots connection is already gone.
Feature/app slam
stefanvogel
changed the title
stefanvogel
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.