Upload page instant-upload + ETA, ePAI copy fix, viewer toolbar defaults - #203
Merged
Conversation
…iewer: toolbar on by default, fix gear/label overlap
- Files now start uploading the instant they're selected, not after a
model is picked, and the old "Upload Progress" bar is gone - the file
list itself (name/type/size) now lives inside the dropzone box.
- The Active-scan card shows an estimated time remaining once inference
is actually running, instead of a content-free indeterminate sweep.
- ePAI's description was undersellling it ("pancreas and tumor" only) -
the backend already emits the full 25-organ segmentation in one pass,
so this just fixes the copy to say so.
- Viewer toolbar now defaults to visible instead of hidden; the floating
gear that appears when it's hidden was sitting almost exactly on top
of the axial pane's label, hiding it - moved clear of it.
…d scheduling - organStats.test.tsx assumed the toolbar started hidden and clicked "Toggle toolbar" to reveal it before opening the Panels menu - now that it's visible by default, that click hid it instead. Dropped the click. - uploadScheduling.test.tsx asserted scan A's dispatch must land before scan B's upload finishes, using real per-chunk timers to create that race. With uploads now starting on file-select instead of on Run, both files' background uploads reliably finished before the test even reached the Run click, so there was nothing left in flight to race against. Replaced the timer-based race with an explicit gate the test controls, so scan B is deterministically still uploading at the moment Run is clicked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_EPAI_TO_VIEWERinauto_segmentor.py) already maps and outputs all 25 organ labels in one pass, confirmed against both this checkout and the live prod.env. Fixed the copy; no backend change was needed.top:12/left:14vs the label'stop:10/left:12), hiding it completely - moved the gear clear of the label.Test plan
npm run build(tsc -b + vite build) passes clean on a throwaway remote clone