Remove the toolbar show/hide toggle - #207
Merged
Merged
Conversation
The floating reveal-gear kept clashing with the axial pane's own label no matter where it was placed, and wasn't worth carrying. Removed both sides of the toggle (the "Hide toolbar" button inside the toolbar and the floating gear that brought it back) rather than leaving a hide action with no way back - the toolbar just always shows now. Cleaned up the now-dead showToolbar state, the --vp-topbar-h effect's conditional branch, and the axial-label positioning hack that only applied while the gear was showing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the toolbar's show/hide toggle entirely - the toolbar is now always visible, no gear button anywhere. The floating reveal-gear kept clashing with the axial pane's own corner label no matter where it was placed across a few attempts, and wasn't worth the trouble for what it bought. Removing just the floating gear would have left the "Hide toolbar" button inside the toolbar as a dead end (click it, no way back without reloading), so both sides of the toggle came out together.
Also cleaned up: the now-dead
showToolbarstate, the--vp-topbar-hsync effect's now-unnecessary conditional branch, and the axial-label positioning hack that only existed to dodge the floating gear.Test plan
npm run build- cleanvitest run- 298/298 passing