Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to version reporting and server URL validation, as well as some minor refactoring. The most significant changes are the addition of a centralized version information utility, enhanced validation for Minecraft server URLs and ports, and updates to the API response structure.
Version reporting improvements:
VersionInfoutility class to load and provide the application version from aversion.propertiesresource.MiscController.serverStatusto return the current version usingVersionInfo.getVersion()instead of a static status string. [1] [2]Server URL and port validation:
MinecraftControllerto correctly capture and validate the port as an optional group.Dependency version update:
pom.xmlfrom1.0.1to1.0.2.