Skip to content

fix(docs): repair typecheck under TypeScript 7 - #64

Merged
pratyush618 merged 2 commits into
masterfrom
fix/docs-typecheck-ts7
Aug 6, 2026
Merged

pratyush618 merged 2 commits into
masterfrom
fix/docs-typecheck-ts7

Conversation

@kartikeya-27

Copy link
Copy Markdown
Contributor

pnpm typecheck is broken on master.

$ pnpm typecheck
tsconfig.json(8,5): error TS5102: Option 'baseUrl' has been removed. Please remove it from your configuration.
  Use '"paths": {"*": ["./*"]}' instead.

What happened

#58 deliberately skipped the TypeScript 7 bump and pinned 6.0.3, because @docusaurus/tsconfig@3.10.2 still ships "baseUrl": "." and TypeScript 7 removed that option. #63 then took the bump to ~7.0.2 anyway, and it merged green — CI has never run typecheck, so nothing caught it.

pnpm build is unaffected: Docusaurus does not typecheck during a build. Only the typecheck script, and editors, are broken.

Removing baseUrl from docs/tsconfig.json does not fix it — the error simply re-points at the inherited config, and no local override can suppress a removed option. @docusaurus/tsconfig is still on 3.10.2, the latest, so there is nothing to upgrade to.

Fix

Stop extending @docusaurus/tsconfig and inline its compilerOptions, with paths resolved relative to docs/tsconfig.json rather than via baseUrl. That is the escape hatch TypeScript's own error message points at, and it keeps the TS 7 bump from #63 rather than reverting it.

This is drift from the upstream config and should be reverted once Docusaurus ships a baseUrl-free tsconfig — there is a comment in the file saying so.

Also: close the gap that let this land

pnpm typecheck now runs in ci-docs.yml, after build-docs so static/wasm/ exists (the playground's imports are unresolvable without it). It is deliberately not in the build-docs composite: the Pages deploy has no use for it, and a type error should fail the PR check rather than a deploy.

Without this step the same class of breakage merges green again.

Verification

pnpm exec tsc --version    7.0.2
pnpm typecheck             exit 0
pnpm build                 exit 0
actionlint                 exit 0

@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@pratyush618, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 77ac5e95-98e0-4953-a196-7af6c51147a4

📥 Commits

Reviewing files that changed from the base of the PR and between b5a5e13 and c85bdf9.

📒 Files selected for processing (2)
  • .github/workflows/ci-docs.yml
  • docs/tsconfig.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pratyush618
pratyush618 force-pushed the fix/docs-typecheck-ts7 branch from f442027 to c85bdf9 Compare August 6, 2026 03:29
@pratyush618
pratyush618 merged commit a36f1d0 into master Aug 6, 2026
9 checks passed
@pratyush618
pratyush618 deleted the fix/docs-typecheck-ts7 branch August 6, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants