fix(docs): repair typecheck under TypeScript 7 - #64
Conversation
|
Warning Review limit reached
Next review available in: 19 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f442027 to
c85bdf9
Compare
pnpm typecheckis broken onmaster.What happened
#58 deliberately skipped the TypeScript 7 bump and pinned 6.0.3, because
@docusaurus/tsconfig@3.10.2still ships"baseUrl": "."and TypeScript 7 removed that option. #63 then took the bump to~7.0.2anyway, and it merged green — CI has never runtypecheck, so nothing caught it.pnpm buildis unaffected: Docusaurus does not typecheck during a build. Only thetypecheckscript, and editors, are broken.Removing
baseUrlfromdocs/tsconfig.jsondoes not fix it — the error simply re-points at the inherited config, and no local override can suppress a removed option.@docusaurus/tsconfigis still on 3.10.2, the latest, so there is nothing to upgrade to.Fix
Stop extending
@docusaurus/tsconfigand inline itscompilerOptions, withpathsresolved relative todocs/tsconfig.jsonrather than viabaseUrl. That is the escape hatch TypeScript's own error message points at, and it keeps the TS 7 bump from #63 rather than reverting it.This is drift from the upstream config and should be reverted once Docusaurus ships a
baseUrl-free tsconfig — there is a comment in the file saying so.Also: close the gap that let this land
pnpm typechecknow runs inci-docs.yml, afterbuild-docssostatic/wasm/exists (the playground's imports are unresolvable without it). It is deliberately not in thebuild-docscomposite: the Pages deploy has no use for it, and a type error should fail the PR check rather than a deploy.Without this step the same class of breakage merges green again.
Verification