fix(format): do not quote pipe fields by default - #1253
Open
11suixing11 wants to merge 1 commit into
Open
Conversation
11suixing11
force-pushed
the
fix/pipe-field-quoting
branch
from
July 30, 2026 13:07
c90aba4 to
4dc7315
Compare
11suixing11
force-pushed
the
fix/pipe-field-quoting
branch
from
July 31, 2026 06:22
4dc7315 to
bc91582
Compare
Author
|
I re-ran this branch after the upstream rebase. Local verification:
GitHub currently reports the Test and dependency-review workflows as |
Author
|
Additional independent verification for this PR:
No code changes were needed in this PR; it remains waiting on the repository's required review/workflow gate. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
|as an escape trigger when the delimiter is still the default comma.||row delimiter.Fixes #787.
Why
The previous character-class regexp included
|as a literal character while trying to express alternation. It also reduced multi-character row delimiters to sets of individual characters. As a result, plain pipe data could be quoted even when it did not contain the configured field or row delimiter.Verification
corepack pnpm exec jest packages/format/__tests__/formatter/FieldFormatter.spec.ts --runInBand(24 tests)corepack pnpm test(37 suites, 606 tests, and all examples)corepack pnpm run build(7 workspace projects)corepack pnpm run format:checkgit diff --check