fix(load): make EP split deep copy more precise - #591
Merged
Conversation
* The `deepcopy(entry)` was copying everything, including the reference to the logger in each class. This was not actually serialisable so could not be deep copied, which led to an error. * This is now fixed by only deep copying the individual parts that need copying. Some copying is needed (otherwise the restricted/public records would overwrite eachother). I tested this locally and it's working for NA61/2/3/4 records
github-project-automation
Bot
moved this from In review 🔍
to To release 🤖
in Sprint Q3 2026 ☀️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deepcopy(entry)was copying everything, including the reference to the logger in each class. This was not actually serialisable so could not be deep copied, which led to an error.This is now fixed by only deep copying the individual parts that need copying. Some copying is needed (otherwise the restricted/public records would overwrite eachother). I tested this locally and it's working for NA61/2/3/4 records
Some other bugs were fixed (the approval request was being fully created on the dry run despite not being inside a UoW context, and sometimes a duplicate report number was being added)