fix(harvester): do not map ISBN to imprint - #955
Open
TahaKhan998 wants to merge 1 commit into
Open
Conversation
TahaKhan998
force-pushed
the
fix/harvester-imprint-isbn-medium
branch
from
September 2, 2026 15:15
3fbb3b5 to
7d796e2
Compare
TahaKhan998
changed the title
TahaKhan998
changed the title
| assert result["place"] == "New York" | ||
| assert result["isbn"] == "978-3-16-148410-0" | ||
| assert imprint == {"place": "New York"} | ||
| assert "isbn" not in imprint |
Contributor
There was a problem hiding this comment.
Is this check needed if we are already checking imprint against it's exact value just above this line?
TahaKhan998
force-pushed
the
fix/harvester-imprint-isbn-medium
branch
from
September 3, 2026 07:31
7d796e2 to
6e93e31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #457
ImprintMapper was putting ISBNs into imprint.isbn, but after checking with Fleur, imprint doesn’t need an ISBN. So this PR stops mapping ISBN into imprint at all. All ISBNs still go to related_identifiers / Related Works, print, online, or no medium, that path was already fine. Added a test that imprint only keeps place and both print and online ISBNs land in related_identifiers.
I looked at IdentifiersMapper and RelatedIdentifiersMapper in identifiers.py, compared it to invenio.cfg, and basically only cds, aleph, cdsrn and apprn go to metadata.identifiers. Everything else like isbn, arxiv, urn, inspire, non CERN report numbers and extra dois go to metadata.related_identifiers, and the main doi goes to pids.doi, not those metadata fields. isbn used to go to identifiers wrongly but that’s already fixed, it only goes to related_identifiers. test_transformer.py covers this too.