feat(permissions): don't allow cross-community request viewing - #958
Open
palkerecsenyi wants to merge 2 commits into
Open
feat(permissions): don't allow cross-community request viewing#958palkerecsenyi wants to merge 2 commits into
palkerecsenyi wants to merge 2 commits into
Conversation
* Added a new generator `SameAsExcept` which is the same as `SameAs` but
excludes generators that are an instance of a certain class.
* Created a new permission in the record permission policy which is the
same as `can_preview` except the `RecordCommunitiesAction("curate")`, so
only members of the community receiving an inclusion/submission request
can view it. Other communities to which the record belongs cannot view
requests that aren't received by them.
* Set this permission in new overrides of the `CommunityInclusion` and
`CommunitySubmission` classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #956
Added a new generator
SameAsExceptwhich is the same asSameAsbutexcludes generators that are an instance of a certain class.
Created a new permission in the record permission policy which is the
same as
can_previewexcept theRecordCommunitiesAction("curate"), soonly members of the community receiving an inclusion/submission request
can view it. Other communities to which the record belongs cannot view
requests that aren't received by them.
Set this permission in new overrides of the
CommunityInclusionandCommunitySubmissionclasses.