Fix funding data lint failure on main - #269
Merged
Merged
Conversation
An empty string fails the schema's date format check, breaking the Lint data files workflow on main. The field is optional, and the page sorts a missing value last, same as before.
✅ Deploy Preview for curiossorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#268 set
deadlineSort: ""on the GitHub Secure Open Source Fund entry to mark it as a rolling deadline. The schema requiresdeadlineSortto be a valid date whenever it's present, so the Lint data files check has been failing onmain:This removes the line.
deadlineSortis optional in the schema, andassets/js/funding-opportunities.jssorts a missing value last, the same as an empty one, so the page looks the same.check-jsonschemapasses locally for bothfunding-opportunities.ymlandtalks.yml.