Skip to content

fix(i18n): add missing translation keys to 5 locale files #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Larslllllll wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −2
Open

fix(i18n): add missing translation keys to 5 locale files #3041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/chainlit/translations/ar-SA.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
"empty": {
"title": "لا توجد رسائل محفوظة بعد",
"description": "ابدأ بإرسال رسالة وقم بتمييزها بنجمة أو ميّز رسالة من محادثاتك السابقة"
}
},
"remove": "Remove favorite"

@cubic-dev-ai cubic-dev-ai Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The value added for chat.favorites.remove in ar-SA.json is the untranslated English string "Remove favorite" inside an otherwise fully Arabic locale file. The PR's own goal is for users on these locales to see translated text rather than a missing-key render, but this change makes Arabic users fall back to English instead of Arabic, so the fix is incomplete. Translate the value to Arabic (e.g. "إزالة المفضلة") rather than copying en-US.json's value.

Note: the sibling locales added proper translations for the same key (de-DE "Favorit entfernen", it "Rimuovi preferito", ko "즐겨찾기 제거"), confirming each locale file should carry its own translated string.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At backend/chainlit/translations/ar-SA.json, line 75:

<comment>The value added for `chat.favorites.remove` in `ar-SA.json` is the untranslated English string "Remove favorite" inside an otherwise fully Arabic locale file. The PR's own goal is for users on these locales to see translated text rather than a missing-key render, but this change makes Arabic users fall back to English instead of Arabic, so the fix is incomplete. Translate the value to Arabic (e.g. "إزالة المفضلة") rather than copying en-US.json's value.

Note: the sibling locales added proper translations for the same key (de-DE "Favorit entfernen", it "Rimuovi preferito", ko "즐겨찾기 제거"), confirming each locale file should carry its own translated string.</comment>

<file context>
@@ -71,7 +71,8 @@
         "description": "ابدأ بإرسال رسالة وقم بتمييزها بنجمة أو ميّز رسالة من محادثاتك السابقة"
-      }
+      },
+      "remove": "Remove favorite"
     },
     "commands": {
</file context>
Suggested change
"remove": "Remove favorite"
" \"remove\": \"إزالة المفضلة\"

},
"commands": {
"button": "أدوات",
Expand Down
3 changes: 2 additions & 1 deletion backend/chainlit/translations/da-DK.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
"empty": {
"title": "Ingen gemte prompts endnu",
"description": "Start med at sende en prompt og markere den med en stjerne, eller vælg en prompt fra tidligere samtaler"
}
},
"remove": "Remove favorite"

@cubic-dev-ai cubic-dev-ai Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The value for chat.favorites.remove is added as the English string "Remove favorite" in the Danish locale file, while every other value in da-DK.json is Danish (e.g. "Fjern vedhæftning"). This key is used as an aria-label in FavoriteButton.tsx, so Danish users (especially screen-reader users) still receive English text, which is exactly the untranslated fallback this PR was meant to fix. Translate the value, e.g. "Fjern favorit". (ar-SA.json has the same problem but is a separate file in this PR.)

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At backend/chainlit/translations/da-DK.json, line 75:

<comment>The value for chat.favorites.remove is added as the English string "Remove favorite" in the Danish locale file, while every other value in da-DK.json is Danish (e.g. "Fjern vedhæftning"). This key is used as an aria-label in FavoriteButton.tsx, so Danish users (especially screen-reader users) still receive English text, which is exactly the untranslated fallback this PR was meant to fix. Translate the value, e.g. "Fjern favorit". (ar-SA.json has the same problem but is a separate file in this PR.)</comment>

<file context>
@@ -71,7 +71,8 @@
         "description": "Start med at sende en prompt og markere den med en stjerne, eller vælg en prompt fra tidligere samtaler"
-      }
+      },
+      "remove": "Remove favorite"
     },
     "commands": {
</file context>
Suggested change
"remove": "Remove favorite"
"remove": "Fjern favorit"

},
"commands": {
"button": "Værktøjer",
Expand Down
6 changes: 6 additions & 0 deletions backend/chainlit/translations/de-DE.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@
"components": {
"MultiSelectInput": {
"placeholder": "Wähle aus..."
},
"DatePickerInput": {
"placeholder": {
"single": "Pick a date",

@cubic-dev-ai cubic-dev-ai Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The de-DE locale file gets components.DatePickerInput.placeholder keys with English values ("Pick a date" / "Pick a date range") verbatim from en-US.json. German users will still see untranslated English placeholder text, which defeats the PR's stated purpose of fixing missing translations for locale users. Translate the values, e.g. single: "Datum auswählen", range: "Datumsbereich auswählen".

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At backend/chainlit/translations/de-DE.json, line 255:

<comment>The de-DE locale file gets `components.DatePickerInput.placeholder` keys with English values ("Pick a date" / "Pick a date range") verbatim from en-US.json. German users will still see untranslated English placeholder text, which defeats the PR's stated purpose of fixing missing translations for locale users. Translate the values, e.g. `single: "Datum auswählen"`, `range: "Datumsbereich auswählen"`.</comment>

<file context>
@@ -249,6 +249,12 @@
+    },
+    "DatePickerInput": {
+      "placeholder": {
+        "single": "Pick a date",
+        "range": "Pick a date range"
+      }
</file context>
Suggested change
"single": "Pick a date",
"single": "Datum auswählen",
"range": "Datumsbereich auswählen"

"range": "Pick a date range"
}
}
}
}
6 changes: 6 additions & 0 deletions backend/chainlit/translations/it.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@
"components": {
"MultiSelectInput": {
"placeholder": "Seleziona..."
},
"DatePickerInput": {
"placeholder": {
"single": "Pick a date",

@cubic-dev-ai cubic-dev-ai Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The added Italian components.DatePickerInput.placeholder values are copied verbatim from en-US.json as English text ("Pick a date" / "Pick a date range"). Every other locale (fr-FR, es, pt-PT, zh-CN, nl, ja) translates this key, so Italian users will see English placeholders. Provide Italian translations, e.g. "Scegli una data" and "Scegli un intervallo di date".

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At backend/chainlit/translations/it.json, line 255:

<comment>The added Italian `components.DatePickerInput.placeholder` values are copied verbatim from en-US.json as English text ("Pick a date" / "Pick a date range"). Every other locale (fr-FR, es, pt-PT, zh-CN, nl, ja) translates this key, so Italian users will see English placeholders. Provide Italian translations, e.g. "Scegli una data" and "Scegli un intervallo di date".</comment>

<file context>
@@ -249,6 +249,12 @@
+    },
+    "DatePickerInput": {
+      "placeholder": {
+        "single": "Pick a date",
+        "range": "Pick a date range"
+      }
</file context>

"range": "Pick a date range"
}
}
}
}
6 changes: 6 additions & 0 deletions backend/chainlit/translations/ko.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,12 @@
"components": {
"MultiSelectInput": {
"placeholder": "선택..."
},
"DatePickerInput": {
"placeholder": {
"single": "Pick a date",

@cubic-dev-ai cubic-dev-ai Bot Sep 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The DatePickerInput placeholders added to this locale file are English strings ("Pick a date"/"Pick a date range") copied from en-US.json, but ko.json is otherwise fully Korean. Every other locale that defines this key (fr-FR, ja, zh-CN, es, ar-SA, da-DK) translates these values, so Korean users will see English text in the date picker. This contradicts the PR's stated goal of showing localized text instead of a missing-key fallback. lint_translations() only checks key structure so this passes lint despite being untranslated. Translate the values, e.g. "날짜 선택"/"날짜 범위 선택".

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At backend/chainlit/translations/ko.json, line 255:

<comment>The `DatePickerInput` placeholders added to this locale file are English strings ("Pick a date"/"Pick a date range") copied from en-US.json, but `ko.json` is otherwise fully Korean. Every other locale that defines this key (fr-FR, ja, zh-CN, es, ar-SA, da-DK) translates these values, so Korean users will see English text in the date picker. This contradicts the PR's stated goal of showing localized text instead of a missing-key fallback. `lint_translations()` only checks key structure so this passes lint despite being untranslated. Translate the values, e.g. "날짜 선택"/"날짜 범위 선택".</comment>

<file context>
@@ -249,6 +249,12 @@
+    },
+    "DatePickerInput": {
+      "placeholder": {
+        "single": "Pick a date",
+        "range": "Pick a date range"
+      }
</file context>

"range": "Pick a date range"
}
}
}
}