Conversation
Refreshes the uv lockfile to pull in the latest fastapi (0.123.5 -> 0.141.1) and starlette (0.50.0 -> 1.6.0) releases. Verified with the full backend test suite and type checker. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113KUXq5rCWWo6wWeMCKPi1
dokterbob
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
September 8, 2026 17:05
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
fastapi >= 0.141 no longer flattens app.include_router(router) into app.routes — it appends a single _IncludedRouter wrapper with no .path attribute, so the old catch-all lookup crashed. Recursing into the wrapper wouldn't help either, since it still reports a full route match for any path the catch-all matches. Move the two directly-added custom routes to the front of app.routes instead of relocating the catch-all. This is version-agnostic: it works whether the catch-all lives at the top level or nested inside an _IncludedRouter, regardless of fastapi/starlette internals. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0113KUXq5rCWWo6wWeMCKPi1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv.lockto pull in the latest fastapi (0.123.5 -> 0.141.1) and starlette (0.50.0 -> 1.6.0) releases viauv lock -P fastapi -P starlettepyproject.tomlconstraint changes needed (both deps use unbounded>=lower pins)Test plan
uv run pytest --cov=chainlit/— 932 passeduv run scripts/type_check.py— no issues found🤖 Generated with Claude Code
https://claude.ai/code/session_0113KUXq5rCWWo6wWeMCKPi1
Summary by cubic
Refreshes
uv.lockforfastapi(0.123.5 → 0.141.1) andstarlette(0.50.0 → 1.6.0), and fixes the e2e auth test for the new FastAPI routing behavior.>=pins, sopyproject.tomlis unchanged; verified with 932 passing tests and the type checker.include_routerintoapp.routes, so the old catch-all relocation crashed; the e2e test now moves the custom auth routes to the front ofapp.routesinstead.Written for commit d09191c. Summary will update on new commits.