feat(sports): make the schedule fetch window configurable - #286
Open
ChuckBuilds wants to merge 2 commits into
Open
feat(sports): make the schedule fetch window configurable#286ChuckBuilds wants to merge 2 commits into
ChuckBuilds wants to merge 2 commits into
Conversation
Reported by a user: Manchester United never appeared even though their next fixture was 22 August, and with favourites turned off the board showed exactly one Premier League game, Arsenal v Coventry. _get_weeks_data() is the partial that serves the display until the background fetch lands. It looked ahead seven days; _fetch_soccer_api_data(), the fetch it substitutes for, looks ahead fourteen. So a fixture inside the real window was simply missing from the board. That gap is invisible in a league that plays daily and severe in one that plays weekly, where a whole matchweek can fall inside it. Reproduced against ESPN on 2026-08-14: -2w..+1w 20260731-20260821 -> 1 event (COV @ ARS, the 21st) -2w..+4w 20260731-20260911 -> 30 events (MAN @ HUL on the 22nd, ...) The Premier League's opening matchweek was 21-24 August, so a +7d horizon caught the Friday opener and hid the other nine fixtures -- exactly the single game the user described. Both horizons now come from one pair of module constants, so the partial cannot silently end up narrower than the fetch it stands in for again. The test reads the full fetch's span out of soccer_managers.py and requires the partial to be at least as wide, rather than hard-coding either number. Mutation-checked: reverting the horizon, re-hardcoding the window in _get_weeks_data, and narrowing the back-window are all caught. Harness clean; soccer's other tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Udr6MfaFLUPhX5Fgo67Jf5
How far back and forward games are fetched was hard-coded at 14 days back and 7 forward, in all nine scoreboards. Days is the wrong unit for a league that plays weekly: a whole matchweek can fall just past a short horizon and never reach the board, which is how a user's favourite team went missing while other clubs in the same league appeared. Both sides are now advanced settings -- schedule_lookback_days and schedule_lookahead_days -- bounded 1 to 60, with a non-numeric or out-of-range value falling back to the default rather than raising. Defaults keep today's behaviour, so nobody's board changes on upgrade. The exception is soccer, whose lookahead moves 7 -> 14 to match the fetch its partial stands in for; that is the reported bug. This is an escape hatch, not the final answer. The right primitive is a game count rather than a day count -- "the next five fixtures" spans five days for a daily league and five weeks for a weekly one, so any fixed number of days is wrong for one of them. That change wants gating on whether favourite teams are configured, so a user browsing a whole league does not pull a season of fixtures to show five. Harness clean on a four-plugin spot check; the two failures across the nine plugins' test suites are the pre-existing missing-src ones also present on main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Udr6MfaFLUPhX5Fgo67Jf5
Contributor
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 38 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #285 — merge that first.
What this adds
schedule_lookback_daysandschedule_lookahead_days, advanced settings on all nine scoreboards. Previously hard-coded at 14 back / 7 forward.Bounded 1–60 days. A non-numeric or out-of-range value falls back to the default rather than raising, so a bad config can't take the plugin down or turn one refresh into a season-wide request.
Defaults keep today's behaviour, so no board changes on upgrade. The one exception is soccer, whose lookahead moves 7 → 14 to match the fetch its partial substitutes for — that's the bug from #285.
Why days is the wrong primitive
Worth stating plainly, because this is an escape hatch rather than the answer.
"Show me the next 5 games" is a count. The days it spans depends entirely on the league's cadence — about 5 days for MLB, about 5 weeks for the Premier League. So any fixed number of days is wrong for one of them, and this setting makes the user do that arithmetic themselves.
The better version sets the horizon from a game count and expands until it's satisfied, gated on whether favourite teams are configured:
Cost: unchanged for no-favourites and for daily leagues (satisfied at the first step); 2–3 requests on a cold cache for a weekly league, which is the case that's currently broken. Future fixtures are static, so a long cache TTL means that's paid once.
The plugin already resolves
self.favorite_teamsinSportsCore.__init__, before the first fetch, so the gate is available where it's needed.Verification
x-advanced: true, bounds 1–60.soccer_managers.pyand requires the configured default to be at least as wide, so the two can't drift apart again.srcones that also fail onmain.Separate finding, not fixed here
Measuring API load on a live rig turned up idle-season polling:
NHLLiveManagerfetched 0 games 22 times in 2 hours — every ~5.5 minutes, year-round, mid-August. Roughly 264 requests/day for one out-of-season league, all returning nothing. That's a defaults problem rather than a configurability one and deserves its own change.