new geom features - #131
Merged
Merged
Conversation
dgirardeau
requested changes
Aug 3, 2026
Contributor
Author
|
The requested changes have been applied |
dgirardeau
approved these changes
Aug 9, 2026
Member
|
Oops, and I realize now that it's when the argument is zero the std::log function will return +inf. Which means that we should also test that l1 is not zero ... |
Contributor
Author
|
Actually since the eigenvalues are sorted, if I am not mistaken, checking only for l3, automatically implies that l1 and l2 are also valid. |
Member
|
Will you open a new PR? |
Contributor
Author
Yes. im opening it asap |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required changes to support the "new geom features" (#2355) PR in the CloudCompare repo