Skip to content

feat: added a new integration test for jenkins pipeline - #7

Open
dlopezallcode wants to merge 1 commit into
testfrom
feat/integration-test
Open

feat: added a new integration test for jenkins pipeline#7
dlopezallcode wants to merge 1 commit into
testfrom
feat/integration-test

Conversation

@dlopezallcode

Copy link
Copy Markdown
Contributor
  • Added integration test coverage for sms.send_with_template / sms.send_single_with_template — tests 53-54, reading the template ID from CCAI_TEST_TEMPLATE_ID.
  • Fixed: send() raised ArgumentError for empty message even when template_id was provided.
  • Fixed: stale positional arguments (sender_phone inserted ahead of options in sms_service.rb/mms_service.rb, never reflected in the progress-tracking tests), a frozen-string test stub causing a FrozenError in upload_image_to_signed_url, and an inconsistent return shape in check_file_uploaded's error path (string key vs. the symbol-keyed response used everywhere else) — aligned to symbol keys, matching the SDK's actual public response format.
  • Bumped version 1.1.0 → 1.2.0 (lib/ccai/version.rb, Gemfile.lock).

@dlopezallcode
dlopezallcode marked this pull request as ready for review August 18, 2026 20:22
@dlopezallcode
dlopezallcode force-pushed the feat/integration-test branch from a44a3ca to e8cb8d2 Compare August 18, 2026 21:19
@dlopezallcode
dlopezallcode force-pushed the feat/integration-test branch from e8cb8d2 to 0d68c78 Compare August 19, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant