feat: added a new integration test for jenkins pipeline - #7
Open
dlopezallcode wants to merge 1 commit into
Open
Conversation
dlopezallcode
marked this pull request as ready for review
August 18, 2026 20:22
dlopezallcode
force-pushed
the
feat/integration-test
branch
from
August 18, 2026 21:19
a44a3ca to
e8cb8d2
Compare
dlopezallcode
force-pushed
the
feat/integration-test
branch
from
August 19, 2026 01:49
e8cb8d2 to
0d68c78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sms.send_with_template/sms.send_single_with_template— tests 53-54, reading the template ID fromCCAI_TEST_TEMPLATE_ID.send()raisedArgumentErrorfor empty message even whentemplate_idwas provided.sender_phoneinserted ahead ofoptionsinsms_service.rb/mms_service.rb, never reflected in the progress-tracking tests), a frozen-string test stub causing aFrozenErrorinupload_image_to_signed_url, and an inconsistent return shape incheck_file_uploaded's error path (string key vs. the symbol-keyed response used everywhere else) — aligned to symbol keys, matching the SDK's actual public response format.lib/ccai/version.rb,Gemfile.lock).