Skip to content

feat: add experimental --exclude-allocations setting#425

Open
not-matthias wants to merge 1 commit into
mainfrom
cod-3016-add-runneraction-setting-to-exclude-memory-allocators
Open

feat: add experimental --exclude-allocations setting#425
not-matthias wants to merge 1 commit into
mainfrom
cod-3016-add-runneraction-setting-to-exclude-memory-allocators

Conversation

@not-matthias

Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 7 untouched benchmarks


Comparing cod-3016-add-runneraction-setting-to-exclude-memory-allocators (ca7c0f6) with main (7ce2c98)

Open in CodSpeed

@not-matthias not-matthias marked this pull request as ready for review June 26, 2026 17:14
@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds an experimental setting to exclude allocation time from measurement results. The main changes are:

  • A new --unstable-exclude-allocations CLI flag and environment variable.
  • Propagation of the setting through executor and run metadata config.
  • Upload metadata serialization that includes the setting only when enabled.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The default upload payload remains unchanged when the new setting is disabled.

Important Files Changed

Filename Overview
src/cli/experimental.rs Adds the experimental CLI flag and forwards it through the existing experimental flags list.
src/executor/config.rs Adds the setting to orchestrator and executor configuration with a default disabled value.
src/run_environment/provider.rs Includes the setting when building runner metadata for uploads.
src/upload/interfaces.rs Adds the upload metadata field and skips it when disabled.
src/upload/upload_metadata.rs Updates metadata hash tests for the new runner field.

Reviews (3): Last reviewed commit: "feat: add experimental --exclude-allocat..." | Re-trigger Greptile

Comment thread src/upload/interfaces.rs
@not-matthias not-matthias force-pushed the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch from 16220f0 to 9f62198 Compare June 26, 2026 17:28
Add an experimental `--exclude-allocations` flag (env
`CODSPEED_EXCLUDE_ALLOCATIONS`) that signals the backend to exclude
memory allocation time from simulation results.

The value is surfaced as `runner.excludeAllocations` in the upload
metadata so the backend can gate comparability and history on it: runs
with different values are not comparable. The field is additive, so the
metadata version stays at 10 and older payloads remain compatible.

COD-3016
@not-matthias not-matthias force-pushed the cod-3016-add-runneraction-setting-to-exclude-memory-allocators branch from 9f62198 to ca7c0f6 Compare July 3, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant