Skip to content

Yk/Volunteer Bugbash #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yurika-Kan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Yk/Volunteer Bugbash #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34d5e9b
bad deep link fixes for volunteer order/request management
Yurika-Kan Sep 6, 2026
3b57da3
fix: NaN requestId silently skips "Request not found" alert
Yurika-Kan Sep 6, 2026
4123b7c
Merge branch 'main' into yk/volunteer-bugbash
Yurika-Kan Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/frontend/src/components/foodRequestManagement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const RequestManagement: React.FC<RequestManagementProps> = ({
}, [selectedFilteredPantries]);

useEffect(() => {
if (!initialRequestId || requests.length === 0) return;
if (initialRequestId === undefined || requests.length === 0) return;
const match = requests.find((r) => r.requestId === initialRequestId);

if (match) {
Expand All @@ -95,9 +95,10 @@ const RequestManagement: React.FC<RequestManagementProps> = ({
setCurrentPage(Math.floor(idx / itemsPerPage) + 1);
}
} else {
setAlertMessage('Request not found.', AlertStatus.ERROR);
navigate(location.pathname, { replace: true });
}
Comment on lines 97 to 100
}, [initialRequestId, requests, navigate, location]);
}, [initialRequestId, requests, navigate, location, setAlertMessage]);

const pantryOptions = [
...new Set(
Expand Down
3 changes: 2 additions & 1 deletion apps/frontend/src/containers/volunteerOrderManagement.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,10 @@ const VolunteerOrderManagement: React.FC = () => {
}
}
} else {
setAlertMessage('Order not found.', AlertStatus.ERROR);

@dburkhart07 dburkhart07 Sep 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look to see if the same copilot comment applies here

navigate(ROUTES.VOLUNTEER_ORDER_MANAGEMENT, { replace: true });
}
}, [searchParams, statusOrders, navigate]);
}, [searchParams, statusOrders, navigate, setAlertMessage]);

// Pre-fill pantry filter from url param, url is kept for back/forward navigation
useEffect(() => {
Expand Down
Loading