Skip to content

Manchester | 26-ITP-May | Joanne O'Malley | Sprint 1 | Exercises#1240

Open
joanne342 wants to merge 18 commits into
CodeYourFuture:mainfrom
joanne342:sprint1
Open

Manchester | 26-ITP-May | Joanne O'Malley | Sprint 1 | Exercises#1240
joanne342 wants to merge 18 commits into
CodeYourFuture:mainfrom
joanne342:sprint1

Conversation

@joanne342

@joanne342 joanne342 commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Sprint 1 coursework

@github-actions

This comment has been minimized.

Sign in to view
@joanne342 joanne342 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@joanne342 joanne342 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@github-actions

This comment has been minimized.

Sign in to view
@joanne342 joanne342 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 9, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 14, 2026
LonMcGregor
LonMcGregor reviewed Jul 14, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on these tasks. So I can better understand your implementation choices, could you answer my comment questions please?

Comment thread Sprint-1/fix/median.js Outdated
Comment thread Sprint-1/implement/max.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 14, 2026
@joanne342 joanne342 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 15, 2026
@LonMcGregor

LonMcGregor commented Jul 15, 2026

Copy link
Copy Markdown

Great work, this task is finished now. Yes, sometimes similar concepts between languages like python and js have subtle differences - it's good you're thinking about these

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joanne342 @LonMcGregor