London | 26-ITP-May | Dipa Sarker | Sprint 1| Sprint-1-exercises#1244
Open
Dipa-Sarker wants to merge 7 commits into
Open
London | 26-ITP-May | Dipa Sarker | Sprint 1| Sprint-1-exercises#1244Dipa-Sarker wants to merge 7 commits into
Dipa-Sarker wants to merge 7 commits into
Conversation
Dipa-Sarker
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 20, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but some areas where you could improve
There was a problem hiding this comment.
Did you run the tests for this file? When I run it, I get a failure, do you also get this?
| @@ -1 +1,10 @@ | |||
| function dedupe() {} | |||
| function dedupe(array) { | |||
| const result = []; | |||
There was a problem hiding this comment.
Are all the lines of code in this function necessary for it to work? Could it be simplified?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the Sprint 1 tasks across the Fix, Implement and Refactor sections.
Implemented functions according to the provided requirements:
maxsumdedupeAdded/verified functionality against the corresponding test cases and checked behavior with different inputs.
Testing
npm test -- fixnpm test -- implement