Manchester | 26-ITP-May | Joanne O'Malley | Sprint 2 | Exercises#1247
Open
joanne342 wants to merge 19 commits into
Open
Manchester | 26-ITP-May | Joanne O'Malley | Sprint 2 | Exercises#1247joanne342 wants to merge 19 commits into
joanne342 wants to merge 19 commits into
Conversation
joanne342
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 20, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task, I've left some comments for you to answer
| @@ -1,3 +1,5 @@ | |||
| function contains() {} | |||
| function contains(obj, property_name) { | |||
| return property_name in obj; | |||
There was a problem hiding this comment.
Does this consider the difference between defined properties and built-in properties?
| const splitByAnds = queryString.split("&"); | ||
|
|
||
| const splitByEquals = splitByAnds.map(x => { | ||
| const match = x.match(/^([^=]*)(?:=(.*))?$/); |
There was a problem hiding this comment.
Can you explain what this regular expression is doing?
|
|
||
| const counts = {}; | ||
| for (const item of uniqueItems) { | ||
| counts[item] = items.filter(x => x === item).length; |
There was a problem hiding this comment.
Imagine I had the input of ['a', 'a', 'a', ...] - How many times will .filter run? Is that an optimal solution?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Sprint 2 coursework