Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Coursework#1248

Open
tomdu3 wants to merge 12 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-1
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 1 | Coursework#1248
tomdu3 wants to merge 12 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-1

Conversation

@tomdu3

@tomdu3 tomdu3 commented Jul 15, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Sprint 1 Tasks

  • fix median
  • implement:
    • dedupe
    • max
    • sum
  • refactor includes
  • stretch , AOC 2018 day 1

@tomdu3 tomdu3 added 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Jul 15, 2026
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 20, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test cases, nice descriptions.

Good work overall, this is complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 20, 2026
@tomdu3

tomdu3 commented Jul 20, 2026

Copy link
Copy Markdown
Author

Thank you for you time and review @LonMcGregor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants