fix(sitemap): emit article slugs via generated manifest, not fs - #128
Merged
Merged
Conversation
sitemap.ts enumerated landing-astro/src/pages/articles with existsSync/readdirSync — inside the deployed Worker there is no filesystem, so /sitemap.xml silently listed zero articles. The sync script now emits src/data/published-articles.ts (biome-formatted) that sitemap.ts imports; the contract test also asserts the manifest cannot drift from the on-disk pages. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sitemap.xmllisted only the 10 static routes — zero of the 13 article pages. Root cause:sitemap.tsenumeratedlanding-astro/src/pages/articlesviaexistsSync/readdirSync, which silently returns empty inside the deployed Worker (no filesystem).landing-astro/scripts/sync-articles.mjsnow emitssrc/data/published-articles.ts(auto biome-formatted, same pattern as karte's emitter) thatsitemap.tsimports instead.Test plan
vitest src/__tests__/sitemap.test.ts— 5/5 (incl. new drift assertion)tsc --noEmit+biome checkclean/sitemap.xmllists/articles/<slug>after deployGenerated with Devin