T3410 mycompassion homepage qa - #391
Merged
Merged
Conversation
…er address/phone/policy link language-specific Re-activates website.option_header_brand_logo (stuck active=False with no per-website override, so the header logo never rendered on any website). Fixes the footer's address icon being top-aligned instead of vertically centered next to a wrapping 2-line address. Adds translatable footer_address/footer_phone/privacy_policy_url fields on website, seeded with the real per-language office contact info and policy page confirmed on the live compassion.ch (FR: Yverdon-les-Bains office; DE/IT: Bern office, distinct phone extensions), replacing the single fixed company address/phone previously shown regardless of language. Also shrinks and adds spacing to the language selector's globe icon so it doesn't crowd the language label. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…on header/menu styling Re-activates the MyCompassion website's copy-on-write override of website_sale.template_header_default (stuck active=False), which is why the gift/basket icon only ever rendered on mobile, never on desktop. Repositions the basket icon to sit inline next to "Give" (always last in the menu, so it stays rightmost regardless of which conditional items show) instead of the generic header icon cluster, drops the default grey circular button background, and reworks its quantity badge (square corners, exact padding, flex-centered digit, no default <sup> vertical offset). Also shrinks the MyCompassion menu text, gives it a neutral grey (theme's --mid-grey token), and fixes its own vertical centering within the header row. Minor unrelated touch-ups picked up along the way: a stray child_profile_timeline.css padding fix and an Italian "Give" translation correction. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
my2_bottom_nav_on_web (off by default, opt-in per country/website) was never enabled for the MyCompassion website, so mobile browsers fell back to the regular top header/footer instead of the intended app-style bottom tab bar, which also doubles as the "mobile footer" this ticket expected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
… styling, and timeline gutter fix to MyCompassion only - The website_sale.header_cart_link visibility gate now only hides the cart item on the MyCompassion website's own old auto-injected spots; every other website keeps its standard cart link (was unconditionally hidden everywhere it isn't explicitly shown). - global.css's menu-text styling now targets a dedicated .my2-nav-link class instead of the generic header .navbar-nav .nav-link, which was shipped in the shared frontend bundle and restyled every other website's navigation. - child_profile_timeline.css's bare .container padding override (unrelated stray fix picked up in an earlier commit) is now scoped to .cd-timeline .container instead of every desktop .container on the site. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ecino
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T3410 — Fix failing quality test: MyCompassion homepage
Summary
QA on the MyCompassion portal homepage (
/my2/dashboard) header/footer flagged around ten distinct visual failures. Most collapsed into three root causes rather than ten separate bugs, plus one genuine missing feature (language-specific footer content) and a round of header/menu visual polish.Root causes fixed
website.option_header_brand_logoview was stuckactive=False(shipsactive="True"by default), so no website rendered a logo at all. Re-activated via migration.my2_bottom_nav_on_web(an opt-in, per-website flag added bymy_compassion_nativefor the app-style bottom tab bar) was never turned on for the MyCompassion website, so mobile browsers fell back to the regular header/footer. The bottom tab bar is the "mobile footer with direct action icons" the QA notes described as missing.website_sale.template_header_defaultstuckactive=False, so the cart-link injection (which the theme re-skins into a gift icon) only ever rendered on the mobile header.Feature: language-specific footer content
Verified directly against production (compassion.ch) that the footer address, phone, and privacy-policy link genuinely differ by language — not a bug report artifact:
/protection-des-donnees//de/datenschutz//it/privacy-e-termini/Added translatable
footer_address/footer_phone/privacy_policy_urlfields onwebsite, falling back to the company's single address/phone when a language isn't set, seeded with the values above.Also fixed
Header/menu polish (not QA-reported, done while in the area)
<sup>carries a browser-default vertical offset that silently fights custom alignment unless explicitly cleared).--mid-greytoken), and its own vertical-centering fix within the header row.Known local-environment-only issue (not fixed, not a code bug)
Most of the QA report's "missing icon" complaints (profile icon, gift icon glyph, language-selector icons, event-banner close button, footer contact icons) trace back to the already-known filestore gap — the underlying SVG attachments are missing from the local filestore snapshot, not from the code. It will be fixed on production.