fix: reject malformed quoted transaction fields - #69
Open
wangtaotaotao95 wants to merge 1 commit into
Open
wangtaotaotao95 wants to merge 1 commit into
wangtaotaotao95 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An amount such as
"10"0in an imported transaction CSV currently becomes100: the parser closes the quote, then silently appends the remaining characters. The resulting spending report succeeds with a different amount.Validate the character following a closing quote and reject malformed suffixes with the existing CSV error. Quoted commas, escaped quotes, embedded newlines, empty fields, and supported record endings remain accepted. Text or spaces outside the closing quote are intentionally rejected.
Validation: the new rejection regression fails on the original parser and passes with the fix. The full suite passes (201 tests), along with lint, root/mobile/worker typechecks, server build, and web/iOS/Android bundle exports on Node 24. Focused tests also cover valid quoted-field boundaries. No UI changes; native device runs and Docker container suites were not run locally.