fix: keep goal-planning ideas attached to their original goal - #70
Open
wangtaotaotao95 wants to merge 1 commit into
Open
wangtaotaotao95 wants to merge 1 commit into
wangtaotaotao95 wants to merge 1 commit into
Conversation
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepting a planning suggestion generated for an existing goal currently creates a second goal and attaches the task to it. The original goal is left without the delegated work, and pausing it does not pause the new task.
Reuse the suggestion's existing goal reference; keep deterministic goal creation for suggestions that do not refer to a goal. Tests cover preserving the original goal and metadata, repeated acceptance producing a single task, pause propagation, and the existing standalone-suggestion behavior. Previously created duplicate goals are not migrated.
Validation: the goal-linking regression fails on the original code and passes with the fix. All 201 tests pass, along with lint, root/mobile/worker typechecks, server build, and web/iOS/Android bundle exports on Node 24. This is a server-only change; live model/provider runs, native device runs, and Docker container suites were not run locally.