fix: reject nonexistent calendar dates before review or dispatch - #71
Open
wangtaotaotao95 wants to merge 2 commits into
Open
wangtaotaotao95 wants to merge 2 commits into
wangtaotaotao95 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendar drafts such as
2026-02-29or2026-04-31pass the current shape checks becauseDate.parsenormalizes them into the following month. Invalid dates can consequently pass proposal validation and reach Google create/update calls.Validate the calendar-date component with the existing Zod ISO date validator, while retaining chronological ordering, explicit offsets, named-zone validation, and the existing timed formats (including minute precision). Regression tests cover invalid start/end dates, leap-year boundaries, valid dates and offsets, and rejection before any Google request.
Validation: before the fix, two regressions failed (35/37 focused tests passed). After the fix, focused tests pass 37/37 and the full suite passes 202/202. Lint, root/mobile/worker typechecks, server build, and web/iOS/Android bundle exports pass on Node 24. Google was tested with fixtures, not a live account; native device runs and Docker container suites were not run locally.