Conversation
…ndpoint overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.env.exampledocuments the optionalOPENAI_BASE_URLendpoint override, but the analogous overrides for the other two providers are missing, even though the model adapter reads them:ANTHROPIC_BASE_URL—apps/server/src/engine/tanstack-agent.ts:35(a trailing/v1is stripped, because the Anthropic SDK adds/v1itself)GOOGLE_GENERATIVE_AI_BASE_URL—apps/server/src/engine/tanstack-agent.ts:44(a trailing/v1betais stripped, because@google/genaiadds the API version itself)Why
Anyone routing Anthropic or Google traffic through a gateway/proxy endpoint has no way to discover these variables from the sample env file, and the suffix handling (
/v1,/v1beta) is easy to get wrong silently. This adds two commented lines mirroring the existingOPENAI_BASE_URLentry, in the same style.Docs-only change; no code touched.
Verification
node_modules/dist): the only readers of these two variables are the adapter lines quoted above.pnpm exec biome check .still passes.