COR-1639: CLI-01: Scan Optimization (SHA Tracking)#123
Open
leenk7991 wants to merge 5 commits into
Open
Conversation
leenk7991
requested review from
Ibrahimrahhal,
asadeddin,
juangaitanv,
tabualhsan and
yhoztak
July 13, 2026 09:03
Reject skip with partial-scan/output flags, case-insensitive complete status, and satisfy clippy::question_mark on CI's Rust 1.97. Co-authored-by: Cursor <cursoragent@cursor.com>
Address RUSTSEC-2026-0194/0195 (quick-xml >=0.41) and RUSTSEC-2026-0204 (crossbeam-epoch >=0.9.20). Update Fortify parser for the quick-xml 0.41 API. Co-authored-by: Cursor <cursoragent@cursor.com>
Ibrahimrahhal
left a comment
Member
There was a problem hiding this comment.
what is the use case here? as this can be confusing --skip-if-scanned may skip scanning because the user is working tree head is already scanned but he have uncommitted changes
Author
yes that's expected, they mentioned they want to skip the scan if the commite was already scanned in the past 24 hours, maybe for CI reruns? |
Keep --skip-if-scanned helpers/tests alongside COR-1647 fail-on malicious gates and COR-1576 wrapper/help UX updates from main. Co-authored-by: Cursor <cursoragent@cursor.com>
juangaitanv
reviewed
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opt-in
--skip-if-scannedavoids re-scanning a commit that already has a completed same project/branch/SHA scan within 24h, andcorgea listsurfaces that SHA.Approach: Use doghouse
git_sha+?sha=/?branch=filters; skip only when opt-in and a recentcompletematch exists (exit 0). Default scan behavior unchanged.src/utils/api.rsgit_shatoScanResponse(#[serde(default)])query_scan_listwith optionalbranch/shaquery paramssrc/scanners/blast.rsfind_recent_matching_scan,parse_created_at,format_scan_agesrc/main.rs--skip-if-scannedflag (blast only; incompatible with--fail/--fail-on)src/list.rsgit_shavia structsrc/wait.rsquery_scan_listparamsTest plan
./harness check--jsongit_sha+?sha=Before
After