Add pending learning object search results after applying filters - #2222
Merged
curlyLasagna merged 1 commit intoJun 11, 2026
Merged
curlyLasagna merged 1 commit into
curlyLasagna merged 1 commit into
Conversation
|
Cwagne17
approved these changes
Jun 5, 2026
Contributor
Author
|
dsoto18
approved these changes
Jun 9, 2026
curlyLasagna
deleted the
feature/sc-39343/modify-browse-page-sticky-filter-popup-to-get-a
branch
June 11, 2026 16:30
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the filter modal in the
BrowseComponentby adding a live preview of the number of matching learning objects as users adjust filters, without affecting the main results until filters are applied. It introduces logic to fetch and display a preview count, ensures the preview is accurate even with rapid filter changes, and improves the user experience on mobile devices.Filter modal preview improvements:
totalLearningObjectsPreviewto track and display the preview count in the filter modal, updating the UI to use this value instead of the maintotalLearningObjects. (src/app/cube/browse/browse.component.html,src/app/cube/browse/browse.component.ts) [1] [2]fetchTotalLearningObjectsPreviewmethod to asynchronously fetch the count of matching objects based on pending filter changes, using a request ID to prevent race conditions. (src/app/cube/browse/browse.component.ts) [1] [2]getQueryWithPendingFiltersto build a query reflecting both applied and pending modal filter changes for accurate preview counts. (src/app/cube/browse/browse.component.ts)User experience improvements:
src/app/cube/browse/browse.component.ts)src/app/cube/browse/browse.component.ts)Data consistency:
fetchLearningObjectsto keeptotalLearningObjectsPreviewin sync with the main result count when a new search is performed. (src/app/cube/browse/browse.component.ts) [1] [2]Screen.Recording.2026-06-04.at.1.42.39.PM.mov