Skip to content

Bug/CLARK-CLIENT-1K/fix-undefined-collection-access - #2278

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/clark-client-1k-builder-navbar-collection
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/clark-client-1k-builder-navbar-collection

Conversation

@sentry

@sentry sentry Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This PR addresses the TypeError: Cannot read properties of undefined (reading 'name') occurring in the learning object builder navbar (builder-navbar.component.html).

Root Cause: The collection object, which is populated asynchronously, was being accessed in the template without proper null guards. Specifically, the *ngIf condition only checked for learningObject?.collection (a string abbreviation) but not the collection object itself. This led to collection.name and collection.hasLogo being dereferenced when collection was still undefined during the asynchronous loading window. An inconsistency was noted as collection?.name was already used safely on line 42, but not on lines 45 and 48.

Fix:

  1. Updated *ngIf guard: Modified the *ngIf condition on line 38 to include && collection. This ensures the block rendering collection.name and collection.hasLogo only executes once the collection object has been successfully resolved and is defined.
  2. Added optional chaining: Applied optional chaining (?.) to collection.name (line 45) and collection.hasLogo (line 48) to prevent errors if collection were ever undefined for other reasons, aligning with the existing safe access pattern on line 42.

Fixes CLARK-CLIENT-1K

This PR was automatically generated by Sentry. You can adjust this setting at any time.

curlyLasagna added a commit that referenced this pull request Sep 15, 2026
* Bug/CLARK-CLIENT-2B/fix-typeerror-empty-collections (#2294)

* Bug/CLARK-CLIENT-2D/fix-typeerror-clark-message-render (#2293)

* Bug/CLARK-CLIENT-22/fix-typeerror-tags-undefined (#2292)

* fix: CLARK-CLIENT-1E - Prevent TypeError on dashboard learning object list (#2291)

* fix(CLARK-CLIENT-1D): Prevent Sentry reports for handled file name validation errors (#2290)

* Bug/CLARK-CLIENT-1/fix expression changed after checked error (#2288)

* Bug/CLARK-CLIENT-16/fix-children-filter-typeerror (#2287)

* fix: Guard Object.assign against null/undefined resourceUris (CLARK-CLIENT-Q) (#2286)

* fix: CLARK-CLIENT-20 Guard against null #header element in setColorScheme (#2285)

* fix: CLARK-CLIENT-1Z - Prevent TypeError on collection description (#2284)

* Bug/CLARK-CLIENT-1Y/fix-context-menu-focus-error (#2283)

* Bug/CLARK-CLIENT-1R/fix-undefined-length-error (#2282)

* fix: Prevent TypeError when skip link target is null (#2280)

* Bug/CLARK-CLIENT-1M/fix-undefined-id-error (#2279)

* Bug/CLARK-CLIENT-1K/fix-undefined-collection-access (#2278)

* Bug/CLARK-CLIENT-1N/fix-trap-focus-null-relatedtarget (#2277)

* Bug/CLARK-CLIENT-1A/fix-undefined-learningobject-access (#2274)

* fix(CLARK-CLIENT-1B): Prevent TypeError when mouse leaves viewport in context menu (#2271)

* Bug/CLARK-CLIENT-6/fix-typeerror-change-password (#2270)

* Bug/CLARK-CLIENT-17/fix-unauthorized-component-auth-injection (#2269)

* Bug/CLARK-CLIENT-Z/fix-typeerror-in-register-username-validation (#2263)

* Bug/CLARK-CLIENT-5/fix-expression-changed-error (#2262)

* Bug/CLARK-CLIENT-10/fix-null-author-typeerror (#2261)

* Bug/CLARK-CLIENT-P/add-optional-chaining-for-auth-user (#2258)

* Bug/CLARK-CLIENT-T/fix-undefined-description (#2257)

* Bug/CLARK-CLIENT-J/fix-materials-component-typeerror (#2252)

* fix da linter

* Allow local development to load due to 9ca2a37 (“fix expression changed error”)

---------

Co-authored-by: Joaquin Villagomez <joaquinvillagomez@Joaquins-MacBook-Air.local>
Co-authored-by: Luis <luis.gcodes@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants