Skip to content

fix: CLARK-CLIENT-1E - Prevent TypeError on dashboard learning object list - #2291

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/clark-client-1e-dashboard-typeerror
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/clark-client-1e-dashboard-typeerror

Conversation

@sentry

@sentry sentry Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

This PR addresses CLARK-CLIENT-1E, a TypeError occurring on the dashboard when evaluating learningObjects.length.

Root Cause:
The loading flag was set to false prematurely in dashboard.component.ts before asynchronous HTTP requests for learning objects (getDraftLearningObjects, getReleasedLearningObjects) had completed. This exposed undefined arrays to the dashboard list component, leading to a crash when .length was accessed.

Changes Made:

  1. dashboard.component.ts: Modified getDraftLearningObjects and getReleasedLearningObjects to await the searchService.getUsersLearningObjects calls. This ensures that the component waits for data to be fetched and assigned before proceeding.
  2. dashboard.component.ts: Initialized workingLearningObjects to an empty array ([]) to prevent potential undefined access if rendering occurs before data is fully loaded. releasedLearningObjects was intentionally left uninitialized to preserve existing query parameter handling logic that relies on its undefined state.
  3. dashboard.component.ts: Ensured this.loading = false is only set after both getDraftLearningObjects and getReleasedLearningObjects have completed their data fetching.

Fixes CLARK-CLIENT-1E

This PR was automatically generated by Sentry. You can adjust this setting at any time.

curlyLasagna added a commit that referenced this pull request Sep 15, 2026
* Bug/CLARK-CLIENT-2B/fix-typeerror-empty-collections (#2294)

* Bug/CLARK-CLIENT-2D/fix-typeerror-clark-message-render (#2293)

* Bug/CLARK-CLIENT-22/fix-typeerror-tags-undefined (#2292)

* fix: CLARK-CLIENT-1E - Prevent TypeError on dashboard learning object list (#2291)

* fix(CLARK-CLIENT-1D): Prevent Sentry reports for handled file name validation errors (#2290)

* Bug/CLARK-CLIENT-1/fix expression changed after checked error (#2288)

* Bug/CLARK-CLIENT-16/fix-children-filter-typeerror (#2287)

* fix: Guard Object.assign against null/undefined resourceUris (CLARK-CLIENT-Q) (#2286)

* fix: CLARK-CLIENT-20 Guard against null #header element in setColorScheme (#2285)

* fix: CLARK-CLIENT-1Z - Prevent TypeError on collection description (#2284)

* Bug/CLARK-CLIENT-1Y/fix-context-menu-focus-error (#2283)

* Bug/CLARK-CLIENT-1R/fix-undefined-length-error (#2282)

* fix: Prevent TypeError when skip link target is null (#2280)

* Bug/CLARK-CLIENT-1M/fix-undefined-id-error (#2279)

* Bug/CLARK-CLIENT-1K/fix-undefined-collection-access (#2278)

* Bug/CLARK-CLIENT-1N/fix-trap-focus-null-relatedtarget (#2277)

* Bug/CLARK-CLIENT-1A/fix-undefined-learningobject-access (#2274)

* fix(CLARK-CLIENT-1B): Prevent TypeError when mouse leaves viewport in context menu (#2271)

* Bug/CLARK-CLIENT-6/fix-typeerror-change-password (#2270)

* Bug/CLARK-CLIENT-17/fix-unauthorized-component-auth-injection (#2269)

* Bug/CLARK-CLIENT-Z/fix-typeerror-in-register-username-validation (#2263)

* Bug/CLARK-CLIENT-5/fix-expression-changed-error (#2262)

* Bug/CLARK-CLIENT-10/fix-null-author-typeerror (#2261)

* Bug/CLARK-CLIENT-P/add-optional-chaining-for-auth-user (#2258)

* Bug/CLARK-CLIENT-T/fix-undefined-description (#2257)

* Bug/CLARK-CLIENT-J/fix-materials-component-typeerror (#2252)

* fix da linter

* Allow local development to load due to 9ca2a37 (“fix expression changed error”)

---------

Co-authored-by: Joaquin Villagomez <joaquinvillagomez@Joaquins-MacBook-Air.local>
Co-authored-by: Luis <luis.gcodes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants