Skip to content

Bug/CLARK-CLIENT-2D/fix-typeerror-clark-message-render - #2293

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/bug/clark-client-2d/fix-typeerror-clark-message-render
Open

sentry[bot] wants to merge 1 commit into
mainfrom
seer/bug/clark-client-2d/fix-typeerror-clark-message-render

Conversation

@sentry

@sentry sentry Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This PR addresses the TypeError: null is not an object (evaluating 'document.querySelector("clark-message .wrapper").offsetHeight') that occurred on /details/info/ pages.

Root Cause:
The column-wrapper.component.ts was attempting to access the offsetHeight of the clark-message .wrapper element synchronously within ngOnInit. However, because this.messageBar was set asynchronously, the clark-message component had not yet been rendered by Angular, causing document.querySelector to return null.

Solution:

  1. Moved DOM access: The logic for calculating columnOffset and columnHeight (which involves querying the DOM for clark-message .wrapper) has been moved from ngOnInit to ngAfterViewInit.
  2. Deferred execution: The DOM query and calculation within ngAfterViewInit are now wrapped in a setTimeout(() => { ... }) to ensure Angular has completed its rendering cycle and the clark-message element is present in the DOM.
  3. Null safety: Added optional chaining (?.offsetHeight ?? 0) to the document.querySelector("clark-message .wrapper") call to gracefully handle cases where the element might still be absent or null, preventing future TypeErrors.

Fixes CLARK-CLIENT-2D

This PR was automatically generated by Sentry. You can adjust this setting at any time.

curlyLasagna added a commit that referenced this pull request Sep 15, 2026
* Bug/CLARK-CLIENT-2B/fix-typeerror-empty-collections (#2294)

* Bug/CLARK-CLIENT-2D/fix-typeerror-clark-message-render (#2293)

* Bug/CLARK-CLIENT-22/fix-typeerror-tags-undefined (#2292)

* fix: CLARK-CLIENT-1E - Prevent TypeError on dashboard learning object list (#2291)

* fix(CLARK-CLIENT-1D): Prevent Sentry reports for handled file name validation errors (#2290)

* Bug/CLARK-CLIENT-1/fix expression changed after checked error (#2288)

* Bug/CLARK-CLIENT-16/fix-children-filter-typeerror (#2287)

* fix: Guard Object.assign against null/undefined resourceUris (CLARK-CLIENT-Q) (#2286)

* fix: CLARK-CLIENT-20 Guard against null #header element in setColorScheme (#2285)

* fix: CLARK-CLIENT-1Z - Prevent TypeError on collection description (#2284)

* Bug/CLARK-CLIENT-1Y/fix-context-menu-focus-error (#2283)

* Bug/CLARK-CLIENT-1R/fix-undefined-length-error (#2282)

* fix: Prevent TypeError when skip link target is null (#2280)

* Bug/CLARK-CLIENT-1M/fix-undefined-id-error (#2279)

* Bug/CLARK-CLIENT-1K/fix-undefined-collection-access (#2278)

* Bug/CLARK-CLIENT-1N/fix-trap-focus-null-relatedtarget (#2277)

* Bug/CLARK-CLIENT-1A/fix-undefined-learningobject-access (#2274)

* fix(CLARK-CLIENT-1B): Prevent TypeError when mouse leaves viewport in context menu (#2271)

* Bug/CLARK-CLIENT-6/fix-typeerror-change-password (#2270)

* Bug/CLARK-CLIENT-17/fix-unauthorized-component-auth-injection (#2269)

* Bug/CLARK-CLIENT-Z/fix-typeerror-in-register-username-validation (#2263)

* Bug/CLARK-CLIENT-5/fix-expression-changed-error (#2262)

* Bug/CLARK-CLIENT-10/fix-null-author-typeerror (#2261)

* Bug/CLARK-CLIENT-P/add-optional-chaining-for-auth-user (#2258)

* Bug/CLARK-CLIENT-T/fix-undefined-description (#2257)

* Bug/CLARK-CLIENT-J/fix-materials-component-typeerror (#2252)

* fix da linter

* Allow local development to load due to 9ca2a37 (“fix expression changed error”)

---------

Co-authored-by: Joaquin Villagomez <joaquinvillagomez@Joaquins-MacBook-Air.local>
Co-authored-by: Luis <luis.gcodes@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants