use external hosted nbviewer instance to preview ipynb files - #2301
Merged
curlyLasagna merged 1 commit intoSep 23, 2026
Merged
curlyLasagna merged 1 commit into
curlyLasagna merged 1 commit into
Conversation
curlyLasagna
requested review from
a team,
Cwagne17,
Low-Key-N,
ebhermann,
imrakeshgulla and
joaquinVill
September 14, 2026 16:59
curlyLasagna
commented
Sep 15, 2026
| <div | ||
| class="notebook-content" | ||
| [class.notebook-content--loading]="isLoading" | ||
| *ngIf="isNotebookPreview && notebookViewerUrl && !hasError"> |
Contributor
Author
There was a problem hiding this comment.
joaquinVill
approved these changes
Sep 22, 2026
ebhermann
approved these changes
Sep 23, 2026
curlyLasagna
deleted the
feature/sc-39945/add-jupyter-notebook-preview-via-nbviewer
branch
September 23, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-09-14.at.12.30.25.PM.mov
TODO:
ipynb.txtdo we inform the user so they could change it or do we change their filename on their behalf?