Fix(mobile): layout fix 900-1200 viewport, mobile side nav scroll fixes - #316
Merged
Conversation
top-nav drops both bar icons at useIsMobileLayout (down lg) while the account popover offered them only below md, so the band had no entry point for either. popover entries now read the same hook; the identity row stays on mdDown, it pairs with the avatar-row details block, not the nav pivot.
simplebar's wrapper is height:inherit, which resolves to auto under flex-grow, so it laid out at the full list height and that height escaped into the drawer paper's own overflow-y:auto. paper.scrollHeight 2461 vs clientHeight 818 with CIPP > Advanced expanded, so the paper dragged the sticky header off the top and carried the pinned sponsor up.
mobile-nav-item hardcoded px:6px at every depth, so CIPP > Advanced > Super Admin read as three siblings. same step side-nav-item already uses.
bmsimp
added a commit
that referenced
this pull request
Aug 19, 2026
PR #316 moved Universal Search and the Light/Dark Mode entry in the account popover from mdDown to useIsMobileLayout, so they now appear as soon as the navigation collapses rather than only on a phone. Update the window-width table and the universal search page to match, and qualify the help and support row, which still moves only below 900px. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Fixes: