Show the channels of ingredients in storage terminal tooltips - #218
Open
rubensworks wants to merge 2 commits into
Open
Show the channels of ingredients in storage terminal tooltips#218rubensworks wants to merge 2 commits into
rubensworks wants to merge 2 commits into
Conversation
When all channels are shown at once, tooltips now indicate in which channel an ingredient is stored, with a quantity breakdown when it is stored in multiple channels. Crafting options indicate their channel as well. This can be disabled with the guiStorageTooltipChannels config. Closes #71 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011TkM3k6R4UTjPCxR4PCHL7
Resolves a conflict in the crafting option tooltip lines: master added an estimated duration line, which is now combined with the channel lines. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011TkM3k6R4UTjPCxR4PCHL7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
When the storage terminal shows all channels at once, tooltips now indicate in which channel an ingredient is available. In a single-channel view nothing is added, as the channel is already known there.
Channel: 0Channels:header followed by one line per channel with its quantity, formatted by the ingredient component's own handler (so fluids readmB, energyFE)guiStorageTooltipChannelsconfigEverything is derived from the per-channel views that the client already receives, so no additional packets are needed. The tooltip lines are now only built while a slot is hovered, where they were previously constructed every frame for every visible slot.
Testing
buildandrunGameTestServerpass. Six game tests were added for the channel lookup and the tooltip lines.Manually verified with clientdevbridge on a network with two item interfaces and three fluid interfaces spread over channels 0 and 1: the multi-channel breakdown, the single-channel line (items, fluids and energy), and the absence of channel lines while a single channel is selected.
🤖 Generated with Claude Code
https://claude.ai/code/session_011TkM3k6R4UTjPCxR4PCHL7
Generated by Claude Code